Fix convert script cannot generate bf16 weights #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wang2yn84
approved these changes
May 26, 2024
Collaborator
wang2yn84
left a comment
wang2yn84
left a comment
There was a problem hiding this comment.
Thank you for the fix!
FanhaiLu1
approved these changes
May 28, 2024
Collaborator
FanhaiLu1
left a comment
FanhaiLu1
left a comment
There was a problem hiding this comment.
Thanks for fixing it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the config logic in
convert_checkpoints.pyis broken, only quantized checkpoint can be generated.After the fix:
--quantize_weightsto control if checkpoint will be quantized.--quantize_typeto specify the quantization type, only effective when--quantize_weightsis true.